refactor: use datatug/cliformat for --format flag#111
Merged
Conversation
Replaces local addFormatFlag helper with cliformat.AddFlag and cliformat.GetFormat — centralises flag registration and format reading. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
trakhimenok
force-pushed
the
feat/cliformat
branch
from
b8b277b to
c7f7dde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addFormatFlaghelper fromflags.go— it registered a bare--formatstring flag with no validation.github.com/datatug/cliformat:cliformat.AddFlag(cmd, "")registers the flag andcliformat.GetFormat(cmd)reads it inselect.go.describe.go,diff.go, andinsert.goare untouched — they usePersistentFlagsor project-specific format sets (ingr,csv,md) thatcliformatdoesn't cover.Test plan
go build ./...passesgo test ./...passes (all 6 packages green)🤖 Generated with Claude Code